Generate service files regardless of whether there are service defini…

…tions in the protos
improbable-eng · May 29, 2018 · 79b28ce · 79b28ce
1 parent be22282
commit 79b28ce
Show file tree

Hide file tree

Showing 31 changed files with 399 additions and 78 deletions.
diff --git a/README.md b/README.md
@@ -86,6 +86,8 @@ protoc \
 
 The `generated` folder will now contain both `pb_service.js` and `pb_service.d.ts` files which you can reference in your TypeScript project to make RPCs.
 
+**Note** Both `js` and `d.ts` service files will be generated regardless of whether there are service definitions in the protos to allow Bazel to consume the plugin.
+
 ```js
 import { UserServiceClient, GetUserRequest } from "../generated/users_pb_service"
 

diff --git a/examples/generated/examplecom/enum_message_pb_service.d.ts b/examples/generated/examplecom/enum_message_pb_service.d.ts
diff --git a/examples/generated/examplecom/enum_message_pb_service.js b/examples/generated/examplecom/enum_message_pb_service.js
diff --git a/examples/generated/examplecom/map_message_pb_service.d.ts b/examples/generated/examplecom/map_message_pb_service.d.ts
diff --git a/examples/generated/examplecom/map_message_pb_service.js b/examples/generated/examplecom/map_message_pb_service.js
diff --git a/examples/generated/examplecom/oneof_message_pb_service.d.ts b/examples/generated/examplecom/oneof_message_pb_service.d.ts
diff --git a/examples/generated/examplecom/oneof_message_pb_service.js b/examples/generated/examplecom/oneof_message_pb_service.js
diff --git a/examples/generated/examplecom/parent_message_v2_pb_service.d.ts b/examples/generated/examplecom/parent_message_v2_pb_service.d.ts
diff --git a/examples/generated/examplecom/parent_message_v2_pb_service.js b/examples/generated/examplecom/parent_message_v2_pb_service.js
diff --git a/examples/generated/examplecom/parent_message_v3_pb_service.d.ts b/examples/generated/examplecom/parent_message_v3_pb_service.d.ts
diff --git a/examples/generated/examplecom/parent_message_v3_pb_service.js b/examples/generated/examplecom/parent_message_v3_pb_service.js
diff --git a/examples/generated/examplecom/primitive_message_v2_pb_service.d.ts b/examples/generated/examplecom/primitive_message_v2_pb_service.d.ts
diff --git a/examples/generated/examplecom/primitive_message_v2_pb_service.js b/examples/generated/examplecom/primitive_message_v2_pb_service.js
diff --git a/examples/generated/examplecom/primitive_message_v3_pb_service.d.ts b/examples/generated/examplecom/primitive_message_v3_pb_service.d.ts
diff --git a/examples/generated/examplecom/primitive_message_v3_pb_service.js b/examples/generated/examplecom/primitive_message_v3_pb_service.js
diff --git a/examples/generated/examplecom/repeated_primitive_message_pb_service.d.ts b/examples/generated/examplecom/repeated_primitive_message_pb_service.d.ts
diff --git a/examples/generated/examplecom/repeated_primitive_message_pb_service.js b/examples/generated/examplecom/repeated_primitive_message_pb_service.js
diff --git a/examples/generated/examplecom/reserved_words_pb_service.d.ts b/examples/generated/examplecom/reserved_words_pb_service.d.ts
diff --git a/examples/generated/examplecom/reserved_words_pb_service.js b/examples/generated/examplecom/reserved_words_pb_service.js
diff --git a/examples/generated/examplecom/simple_pb_service.d.ts b/examples/generated/examplecom/simple_pb_service.d.ts
diff --git a/examples/generated/examplecom/simple_pb_service.js b/examples/generated/examplecom/simple_pb_service.js
diff --git a/examples/generated/examplecom/simplevalue_pb_service.d.ts b/examples/generated/examplecom/simplevalue_pb_service.d.ts
diff --git a/examples/generated/examplecom/simplevalue_pb_service.js b/examples/generated/examplecom/simplevalue_pb_service.js
diff --git a/examples/generated/examplecom/well_known_message_pb_service.d.ts b/examples/generated/examplecom/well_known_message_pb_service.d.ts
diff --git a/examples/generated/examplecom/well_known_message_pb_service.js b/examples/generated/examplecom/well_known_message_pb_service.js
diff --git a/examples/generated/othercom/external_child_message_pb_service.d.ts b/examples/generated/othercom/external_child_message_pb_service.d.ts
diff --git a/examples/generated/othercom/external_child_message_pb_service.js b/examples/generated/othercom/external_child_message_pb_service.js
diff --git a/examples/generated/othercom/external_enum_pb_service.d.ts b/examples/generated/othercom/external_enum_pb_service.d.ts
diff --git a/examples/generated/othercom/external_enum_pb_service.js b/examples/generated/othercom/external_enum_pb_service.js
-Original file line number
+Diff line change
@@ Expand Up / @@ -86,6 +86,8 @@ protoc \ @@
     The `generated` folder will now contain both `pb_service.js` and `pb_service.d.ts` files which you can reference in your TypeScript project to make RPCs.
+    **Note** Both `js` and `d.ts` service files will be generated regardless of whether there are service definitions in the protos to allow Bazel to consume the plugin.
     ```js
     import { UserServiceClient, GetUserRequest } from "../generated/users_pb_service"
@@ Expand Down @@