Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client streaming stub generation uses wrong type #132

Closed
johanbrandhorst opened this issue Oct 20, 2018 · 0 comments
Closed

Client streaming stub generation uses wrong type #132

johanbrandhorst opened this issue Oct 20, 2018 · 0 comments

Comments

@johanbrandhorst
Copy link
Contributor

It seems to be using the responseType instead of the requesType, see

ts-protoc-gen/src/service/grpcweb.ts

Line 534 in 51f57ea

printer.printLn(`${method.nameAsCamelCase}(metadata?: grpc.Metadata): RequestStream<${method.responseType}>;`);

@johanbrandhorst johanbrandhorst mentioned this issue Oct 20, 2018
Merged
johanbrandhorst added a commit to johanbrandhorst/ts-protoc-gen that referenced this issue Oct 20, 2018
@johanbrandhorst
Correct generated client, bidi stream method stubs
5187c4e 
Fixes improbable-eng#132, improbable-eng#133
johanbrandhorst added a commit to johanbrandhorst/ts-protoc-gen that referenced this issue Oct 20, 2018
@johanbrandhorst
Correct generated client, bidi stream method stubs
93c4444 
Fixes improbable-eng#132, improbable-eng#133
jonnyreeves pushed a commit that referenced this issue Oct 20, 2018
@johanbrandhorst @jonnyreeves
Correct generated client, bidi stream method stubs (#131)
217169b 
Fixes #132, #133
chrisgervang pushed a commit to chrisgervang/flowtype-protoc-gen that referenced this issue Nov 14, 2018
@johanbrandhorst @chrisgervang
Correct generated client, bidi stream method stubs (improbable-eng#131)
0a44695 
Fixes improbable-eng#132, improbable-eng#133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanbrandhorst