Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't deploy .deb files to npm #121

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Don't deploy .deb files to npm #121

merged 1 commit into from
Oct 14, 2018

Conversation

jonnyreeves
Copy link
Contributor

Fixes #117

@easyCZ
Copy link
Contributor

easyCZ commented Oct 13, 2018

How are these .deb produced?

@jonnyreeves
Copy link
Contributor Author

During the bazel install step

@easyCZ
Copy link
Contributor

easyCZ commented Oct 13, 2018

Thanks for raising. I'll try to do some investigation to see why bazel is outputting outside of the bazel directory.

@jonnyreeves jonnyreeves merged commit 0553580 into master Oct 14, 2018
@jonnyreeves jonnyreeves deleted the jonnyreeves-patch-1 branch October 14, 2018 09:21
@jonnyreeves
Copy link
Contributor Author

Using unpkg.com confirms that the bazel deb is no longer deployed to npm: https://unpkg.com/[email protected]/

@jonnyreeves
Copy link
Contributor Author

@easyCZ actually, you were right to question this; the .deb is downloaded during the travis build process [here](- wget https://github.com/bazelbuild/bazel/releases/download/0.11.0/bazel_0.11.0-linux-x86_64.deb). The correct fix for this is to remove it after it's been installed and before the project is built.

coltonmorris pushed a commit to coltonmorris/ts-protoc-gen that referenced this pull request Oct 17, 2018
Merge remote-tracking branch 'upstream/master'
82405eb 
* upstream/master:
  Transport member of ServiceClientOptions should be optional (improbable-eng#125)
  Allow canceling unary calls (improbable-eng#124)
  CI should check that generated code has been committed (improbable-eng#127)
  Bumped to v0.7.8-pre (improbable-eng#123)
  Prepare 0.7.7 release (improbable-eng#112)
  Clean up Bazel Installation during Travis Build (improbable-eng#122)
  Don't deploy .deb files to npm (improbable-eng#121)
  Fix snake_cased oneof message are generated to incorrect types (improbable-eng#118)
  Make ServiceError optionally null (improbable-eng#116)
  Be explicit about the need for a CommonJS environment. (improbable-eng#108)
  Replace usage of `Object.assign` (improbable-eng#110)
  Add hint for Windows users (improbable-eng#107)
  Collapse Bazel Instructions in README (improbable-eng#106)
  Implement Client Streaming and BiDi Streaming for grpc-web (improbable-eng#82)
  Add support for jstype annotation (improbable-eng#104)
chrisgervang pushed a commit to chrisgervang/flowtype-protoc-gen that referenced this pull request Nov 14, 2018
@jonnyreeves @chrisgervang
Don't deploy .deb files to npm (improbable-eng#121)
e9c9720 
Fixes improbable-eng#117
chrisgervang added a commit to chrisgervang/flowtype-protoc-gen that referenced this pull request Nov 16, 2018
@chrisgervang
Revert "Don't deploy .deb files to npm (improbable-eng#121)"
ab59e5a 
This reverts commit e9c9720.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnyreeves @easyCZ