Support Bazel build #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your submission, we also make use of Bazel at improbable 😀 Please can you modify the Travis build configuration to ensure that the hazel build is also executed? Thanks |
adamyi
force-pushed
the
bazel
branch
2 times, most recently
from
b3fc26a to
e6fccf8
Compare
jonnyreeves
suggested changes
Mar 2, 2018
.gitignore
Outdated
| @@ -1,10 +1,12 @@ | |||
| .vscode | |||
| node_modules | |||
| node-debug.log | |||
| package-lock.json | |||
There was a problem hiding this comment.
This change is unrelated, please revert
adamyi
force-pushed
the
bazel
branch
2 times, most recently
from
7c1f057 to
eaecf15
Compare
|
Got Travis CI working now. |
adamyi
commented
Mar 2, 2018
| "babel": "^6.5.2", | ||
| "chai": "^3.5.0", | ||
| "mocha": "^3.2.0", | ||
| "source-map-support": "^0.4.14", | ||
| "tslint": "^4.5.1", | ||
| "tslint": "^5.9.1", |
There was a problem hiding this comment.
The old version would depend on an old version of tsutils, which is incompatible with the new Bazel typescript rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support building with Bazel.
To build it, run
The built artifact will be at
bazel-bin/bin/protoc-gen-ts.This would facilitate supporting Protobuf in Bazel-built ts projects. This CL is made on top of the original WIP but seemingly abandoned PR #24.
/cc @pcj @MarcusLongmuir