Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/refactor grpcweb service codegen #51

Merged
merged 4 commits into from
Apr 2, 2018
Merged

Feature/refactor grpcweb service codegen #51

merged 4 commits into from
Apr 2, 2018

Conversation

jonny-improbable
Copy link
Contributor

Simple refactor of the grpc-web service code generation. The main goal was to split the code-gen into two distinct phases:

  1. Build up data structures for rendering
  2. Render data structures as a string

I've also take the opportunity to re-organise the code, moving the grpc-web service code-gen into its own folder (ts/service/grpcweb.ts).

@jonny-improbable jonny-improbable requested a review from easyCZ March 28, 2018 07:47
easyCZ
easyCZ approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. This will unblock adding tests and a future refactor into a Visitor pattern.

@easyCZ easyCZ merged commit 9aa6992 into master Apr 2, 2018
@easyCZ easyCZ deleted the feature/refactor-grpcweb-service-codegen branch April 2, 2018 14:58
@jonnyreeves jonnyreeves mentioned this pull request May 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonny-improbable @easyCZ