Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord embed now has a black stripe for cobalt.tools #738

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SpiritAxolotl
Copy link

Simple one-line change that makes the little stripe on cobalt embeds black instead of the default.
image

@SpiritAxolotl
Copy link
Author

@dumbmoron can you approve this perchance

@wukko
Copy link
Member

wukko commented Sep 14, 2024

does this affect the experience of page loading in browsers that use the accent color? i’d imagine the color would flicker on android in chrome, but i may be wrong

@SpiritAxolotl
Copy link
Author

SpiritAxolotl commented Sep 14, 2024

more information on the tag property: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name/theme-color

it also seems like you can use the media property to make dark/light mode versions and I could just change that with js if the user overrides it? that would require more work on my part to do that. should I change the pr to a draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants