-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shape check for arbitrary rf/grad #22
Labels
bug
Something isn't working
Comments
Could you share code to reproduce this? |
`from pypulseq.opts import Opts from pypulseq.Sequence.sequence import Sequence from pypulseq.make_arbitrary_rf import make_arbitrary_rf import numpy as np import math system = Opts(max_grad=32, grad_unit='mT/m', max_slew=130, slew_unit='T/m/s', grad_raster_time=10e-6, rf_raster_time= 10e-6) seq = Sequence(system) rf = np.ones((1, 300), dtype=complex) #rf = np.ones((300, 1), dtype=complex) rf_waveform, _ = make_arbitrary_rf(flip_angle=90 * 180 / math.pi, system=system, signal=rf) seq.add_block(rf_waveform)` |
Running the code above as it is, it would break. |
sravan953
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
May 5, 2020
Thank you! Commit 0f55671 should have fixed this. Please let me know so I can close the issue. |
Yes, this fixes the above problem. You can close the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
If a waveform of shape (1,x) is used to construct arbitrary rf or gradient events they cannot be successfully added to a block.
Describe the solution you'd like
Perform shape checking
The text was updated successfully, but these errors were encountered: