Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer definitions are missed in write_seq.py #49

Closed
sravan953 opened this issue Apr 14, 2021 · 0 comments
Closed

Integer definitions are missed in write_seq.py #49

sravan953 opened this issue Apr 14, 2021 · 0 comments
Assignees

Comments

@sravan953
Copy link
Collaborator

Describe the bug
Originally reported by @mavel101 from #45:
The set_definition function accepts an integer as value, but in the write_seq an integer is only accepted as part of a list, tuple or ndarray not as a single integer. Changing this line in the write_seq:

elif isinstance(values[block_counter], float):
                output_file.write(f'{values[block_counter]:0.9g} ')

to

elif isinstance(values[block_counter], (int,float)):
                output_file.write(f'{values[block_counter]:0.9g} ')

would solve this.

To Reproduce

  • Share the pulse sequence code, if possible.
  • If not, isolate the bug to a particular pulse sequence event by iteratively writing/plotting the sequence one event at a time.
  • If the sequence successfully writes/plots with individual pulse sequence events, isolate the bug by writing/plotting the sequence by successively adding events.

Desktop (please complete the following information):

  • pypulseq version: 1.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant