Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage path and use pipefail #243

Closed
wants to merge 17 commits into from
Closed

Fix coverage path and use pipefail #243

wants to merge 17 commits into from

Conversation

schuenke
Copy link
Collaborator

@schuenke schuenke commented Jan 24, 2025 •
edited
Loading

superseded by #246

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

❌ PyTest Coverage Report was not found

Check the PyTest Workflow

@schuenke schuenke mentioned this pull request Jan 24, 2025
Open
@schuenke schuenke changed the title Fix coverage path and permission of test workflow Fix coverage path and use pipefail Jan 24, 2025
@fzimmermann89
Copy link
Collaborator

fzimmermann89 commented Jan 30, 2025 •
edited
Loading

The coverage comment is not updated when the test fails

@fzimmermann89
Copy link
Collaborator

Also, you can use
actions/runner-images#4459 (comment)
and just set the shell to bash to get pipefail

@schuenke
Copy link
Collaborator Author

schuenke commented Feb 5, 2025

superseded by #246

@schuenke schuenke closed this Feb 5, 2025
@schuenke schuenke deleted the fix_workflows branch February 6, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzimmermann89 fzimmermann89 Awaiting requested review from fzimmermann89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuenke @fzimmermann89