Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient waveforms fix #84

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

btasdelen
Copy link
Collaborator

Tries to fix #72.

Copy link
Collaborator

@sravan953 sravan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, waiting to merge this PR!

pypulseq/Sequence/sequence.py Outdated Show resolved Hide resolved
pypulseq/Sequence/sequence.py Outdated Show resolved Hide resolved
@btasdelen btasdelen requested a review from sravan953 August 10, 2022 21:03
@sravan953 sravan953 merged commit 86d24e3 into imr-framework:dev Aug 16, 2022
btasdelen added a commit to btasdelen/pypulseq that referenced this pull request Aug 17, 2022
* Fix gradient_waveform func. Empty check and asarray cast in points_to_waveform.
* Fix incorrect array assignment in gradient_waveforms.
@btasdelen btasdelen deleted the gradient_waveforms_fix branch August 20, 2022 22:18
@fzimmermann89 fzimmermann89 mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence.gradient_waveforms() does not interpolate trapezoids with gradient raster time.
2 participants