Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up v1 draft folder #132

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

TomHennen
Copy link
Contributor

@TomHennen TomHennen commented Feb 6, 2023

Sets up a v1.0-draft folder to make changes related to v1.

These are copies of the corresponding files in spec/ with the only change made being the version number bump.

refs #130

This is by no means final, it's just to give us a place to iterate on v1.

refs in-toto#130

Signed-off-by: Tom Hennen <[email protected]>
Signed-off-by: Tom Hennen <[email protected]>
@TomHennen TomHennen requested review from marcelamelara and a team February 6, 2023 18:06
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Should we create a corresponding v0.1 folder too? Or not until we release v1.0?

@TomHennen
Copy link
Contributor Author

SGTM. Should we create a corresponding v0.1 folder too? Or not until we release v1.0?

Yeah I figured we'd do that when we publish 1.0 (basically moving v1.0-draft/ to v1.0/) Make sense?

@marcelamelara
Copy link
Contributor

SGTM. Should we create a corresponding v0.1 folder too? Or not until we release v1.0?

Yeah I figured we'd do that when we publish 1.0 (basically moving v1.0-draft/ to v1.0/) Make sense?

Yes, and 0.1.0 should probably also get its own folder then.

@marcelamelara marcelamelara requested a review from a team February 6, 2023 20:40
Copy link
Member

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these are just copies for now?

Edit: it says so above LGTM!

@marcelamelara marcelamelara merged commit b14a0c5 into in-toto:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants