Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation: Add graphic to visualize relationships between layers #166

Merged
merged 5 commits into from
Mar 27, 2023

Conversation

dasiths
Copy link
Contributor

@dasiths dasiths commented Mar 23, 2023

This PR updates the specification landing page to include a graphic that visualises the relationship between the envelope, statement and predicate layers.

This is intended to help someone new to the framework easily understand the key layers.

spec/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dasiths for this PR, super helpful! I have a few nits, but think this is ready to be accepted otherwise.

images/specification.png Outdated Show resolved Hide resolved
spec/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

images/specification.excalidraw Outdated Show resolved Hide resolved
spec/README.md Outdated Show resolved Hide resolved
spec/README.md Outdated Show resolved Hide resolved
@dasiths dasiths requested a review from TomHennen March 27, 2023 14:19
@dasiths
Copy link
Contributor Author

dasiths commented Mar 27, 2023

Thanks for the review and approval @TomHennen @marcelamelara.

@marcelamelara marcelamelara merged commit 95a461d into in-toto:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants