Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate attestation libraries using protoc #192

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

adityasaky
Copy link
Member

This PR adds a GitHub Actions workflow to regenerate libraries using protoc. The action is triggered once a week as well as when something is pushed to main.

(We need the scheduled run as protoc is configured to use version 3.x so we may have newer tooling even if there are no changes here for a week to main.)

@adityasaky adityasaky requested a review from a team as a code owner April 14, 2023 20:20
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do we need to update the documentation in docs/protos.md to remove the explicit requirement to regenerate the language bindings manually?

.github/workflows/make-protos.yml Show resolved Hide resolved
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Also, my apologies if my other questions are daft, I've never done GitHub Actions before.

Finally, did we have some other documentation that suggests people regenerate the libs when modifying the protos? I'd assume that would change now?

.github/workflows/make-protos.yml Show resolved Hide resolved
.github/workflows/make-protos.yml Show resolved Hide resolved
.github/workflows/make-protos.yml Show resolved Hide resolved
@adityasaky adityasaky force-pushed the protoc-action branch 2 times, most recently from 60d66a7 to 6321c22 Compare April 14, 2023 20:51
@adityasaky
Copy link
Member Author

Also amended the protos doc to instruct contributors not to regenerate libraries.

@adityasaky
Copy link
Member Author

Updated go_setup target in Makefile to be a go install of the Go generator. Also removed the explicit versioning so the one in go.mod is used by default.

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

.github/workflows/make-protos.yml Show resolved Hide resolved
.github/workflows/make-protos.yml Show resolved Hide resolved
@marcelamelara marcelamelara merged commit 3df726c into in-toto:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants