-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate attestation libraries using protoc #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do we need to update the documentation in docs/protos.md to remove the explicit requirement to regenerate the language bindings manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Also, my apologies if my other questions are daft, I've never done GitHub Actions before.
Finally, did we have some other documentation that suggests people regenerate the libs when modifying the protos? I'd assume that would change now?
60d66a7
to
6321c22
Compare
Also amended the protos doc to instruct contributors not to regenerate libraries. |
Signed-off-by: Aditya Sirish <[email protected]>
6321c22
to
a4a6dd2
Compare
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
This PR adds a GitHub Actions workflow to regenerate libraries using protoc. The action is triggered once a week as well as when something is pushed to main.
(We need the scheduled run as protoc is configured to use version
3.x
so we may have newer tooling even if there are no changes here for a week to main.)