Add Java bindings #205
Merged
Add Java bindings #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelamelara
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Thank you @adityasaky ! Could you please add a java/README in this style ?
adityasaky
force-pushed
the
java-bindings
branch
from
099d754 to
f74ee0b
Compare
|
Updated with java_package as well. I'm not a Java person per se, so I hope someone can help me figure out what the package structure should look like. |
|
I thought we didn't like using io.intoto since intoto.io is owned by some other company? Can you use 'io.in-toto' or 'io.in_toto'? |
|
True, but I believe there are best practices concerns as well. I took a look at in-toto-java along the way. @Alos perhaps you could help out too? |
|
+1 to Tom's comment about the io.intoto package namespace. Looks like in-toto-java uses the |
adityasaky
force-pushed
the
java-bindings
branch
from
f74ee0b to
e5fb734
Compare
|
Updated the package name. |
adityasaky
force-pushed
the
java-bindings
branch
from
e5fb734 to
c3a5f0f
Compare
marcelamelara
approved these changes
Apr 27, 2023
Signed-off-by: Aditya Sirish <[email protected]>
adityasaky
force-pushed
the
java-bindings
branch
from
c3a5f0f to
9294e52
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173