Use ResourceDescriptor for statement subjects #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasaky
commented
May 3, 2023
MarkLodato
reviewed
May 3, 2023
adityasaky
force-pushed
the
use-rd-statement
branch
2 times, most recently
from
0a7581a to
6da3cf1
Compare
adityasaky
commented
May 3, 2023
MarkLodato
reviewed
May 4, 2023
adityasaky
force-pushed
the
use-rd-statement
branch
from
6da3cf1 to
d94dc55
Compare
MarkLodato
approved these changes
May 5, 2023
adityasaky
force-pushed
the
use-rd-statement
branch
from
d94dc55 to
568d2b1
Compare
adityasaky
requested review from
TomHennen,
mikhailswift,
joshuagl,
pxp928 and
marcelamelara
MarkLodato
approved these changes
May 5, 2023
Update proto definitions, docs/validation etc to reflect this change. Signed-off-by: Aditya Sirish <[email protected]>
adityasaky
force-pushed
the
use-rd-statement
branch
from
568d2b1 to
f37f9f4
Compare
marcelamelara
approved these changes
May 8, 2023
This was referenced May 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates statement.proto to use ResourceDescriptor which changes the number of
digestfrom 2 to 3.