Add proto for test result predicate #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasaky
force-pushed
the
add-test-result-proto
branch
from
13efbe4 to
fc14432
Compare
marcelamelara
approved these changes
May 26, 2023
There was a problem hiding this comment.
LGTM, thanks @adityasaky ! Only one small nit. I assume you'll be pushing validator APIs and/or test cases in a future PR?
Also makes title of the predicate singular Signed-off-by: Aditya Sirish <[email protected]>
adityasaky
force-pushed
the
add-test-result-proto
branch
from
fc14432 to
d6090c0
Compare
yep! |
|
@pxp928 @TomHennen @joshuagl @mikhailswift can I get a second review on this? Thanks! |
pxp928
approved these changes
May 31, 2023
|
Yes, that's the idea. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.