Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common action items for the new predicate vetting process #320

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

marcelamelara
Copy link
Contributor

@marcelamelara marcelamelara commented Jan 22, 2024

This PR explicitly adds three main common action items that are part of the vetting process for new predicate types:

  • updating the list of existing predicates
  • adding a proto definition to generate language bindings
  • updating the URL redirects for predicateType URIs that are defined within the in-toto.io/attestation namespace

fixes #313

@marcelamelara marcelamelara requested a review from a team as a code owner January 22, 2024 23:01
@marcelamelara marcelamelara force-pushed the update-predicate-action-items branch from f0ce788 to e089202 Compare January 22, 2024 23:03
Copy link
Member

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/new_predicate_guidelines.md Outdated Show resolved Hide resolved
Signed-off-by: Marcela Melara <[email protected]>
@adityasaky
Copy link
Member

Possibly out of scope for this PR but can this guide be updated to include inline ITE-9 recommendations so we don't turn ITE-9 into a living doc?

@marcelamelara
Copy link
Contributor Author

Possibly out of scope for this PR but can this guide be updated to include inline ITE-9 recommendations so we don't turn ITE-9 into a living doc?

Hmm, it may be within scope. Do you have a specific list of recommendations that we can already add?

@adityasaky
Copy link
Member

  1. Open a PR following [ITE-9] formatting guidelines.

Probably just inlining this so the ITE-9 reference is just for where it came from. Any future formatting updates then don't need to happen in ITE-9.

@marcelamelara
Copy link
Contributor Author

Probably just inlining this so the ITE-9 reference is just for where it came from. Any future formatting updates then don't need to happen in ITE-9.

@adityasaky we figured that ITE-9 is the authoritative source for predicate spec formatting, are you suggesting that any future format updates should be specified here instead?

@adityasaky
Copy link
Member

adityasaky commented Feb 5, 2024

@adityasaky we figured that ITE-9 is the authoritative source for predicate spec formatting, are you suggesting that any future format updates should be specified here instead?

yes. That'd enable ITE-9 to be accepted and then move into "final" status, for example (https://github.com/in-toto/ITE/blob/master/ITE/1/README.adoc#ite-workflow). My understanding of the ITE process is that they're not intended to be living documents, even if changes are expected to be far and few in between.

So re-specifying the format in the attestation docs + stating they originated from ITE-9 is probably fine?

@marcelamelara
Copy link
Contributor Author

My understanding of the ITE process is that they're not intended to be living documents, even if changes are expected to be far and few in between.

So re-specifying the format in the attestation docs + stating they originated from ITE-9 is probably fine?

Thanks for the clarification. Now this makes sense. My take is to handle this in a dedicated PR, though.

@marcelamelara
Copy link
Contributor Author

@pxp928 @TomHennen Given the discussion with @adityasaky , are you with merging this PR as-is now?

@adityasaky
Copy link
Member

Thanks for the clarification. Now this makes sense. My take is to handle this in a dedicated PR, though.

Sounds good to me!

@pxp928 pxp928 merged commit df89beb into in-toto:main Feb 5, 2024
8 checks passed
@marcelamelara marcelamelara deleted the update-predicate-action-items branch August 30, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should in-toto managed vetted predicates type URIs point to GitHub repo?
4 participants