-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common action items for the new predicate vetting process #320
Add common action items for the new predicate vetting process #320
Conversation
Signed-off-by: Marcela Melara <[email protected]>
f0ce788
to
e089202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Marcela Melara <[email protected]>
69d7402
to
6967da5
Compare
Signed-off-by: Marcela Melara <[email protected]>
Possibly out of scope for this PR but can this guide be updated to include inline ITE-9 recommendations so we don't turn ITE-9 into a living doc? |
Hmm, it may be within scope. Do you have a specific list of recommendations that we can already add? |
Probably just inlining this so the ITE-9 reference is just for where it came from. Any future formatting updates then don't need to happen in ITE-9. |
@adityasaky we figured that ITE-9 is the authoritative source for predicate spec formatting, are you suggesting that any future format updates should be specified here instead? |
yes. That'd enable ITE-9 to be accepted and then move into "final" status, for example (https://github.com/in-toto/ITE/blob/master/ITE/1/README.adoc#ite-workflow). My understanding of the ITE process is that they're not intended to be living documents, even if changes are expected to be far and few in between. So re-specifying the format in the attestation docs + stating they originated from ITE-9 is probably fine? |
Thanks for the clarification. Now this makes sense. My take is to handle this in a dedicated PR, though. |
@pxp928 @TomHennen Given the discussion with @adityasaky , are you with merging this PR as-is now? |
Sounds good to me! |
This PR explicitly adds three main common action items that are part of the vetting process for new predicate types:
fixes #313