Expose known algorithms #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds fine, but I'd like to be involved in any discussion of any
proposal to add something akin to negotiation of which algorithms should be
used for different operations...
…On Wed, Jan 15, 2025 at 6:43 PM Puerco ***@***.***> wrote:
This PR adds a change to expose the known algorithms in a new type to let
programs using the library know the standardized algorithm names. The type
has a function to return the expected algorithm length that can be used to
validate a hex representation of a hash.
/cc @marcelamelara <https://github.com/marcelamelara>
Signed-off-by: Adolfo García Veytia (Puerco) ***@***.***
------------------------------
You can view, comment on, or merge this pull request online at:
#427
Commit Summary
- 31e4de6
<31e4de6>
Expose known algorithms
File Changes
(1 file <https://github.com/in-toto/attestation/pull/427/files>)
- *M* go/v1/resource_descriptor.go
<https://github.com/in-toto/attestation/pull/427/files#diff-6463e980f18991b3445b1d4f266d815a768aeb34c9422c72afa91ee2c6c28f66>
(71)
Patch Links:
- https://github.com/in-toto/attestation/pull/427.patch
- https://github.com/in-toto/attestation/pull/427.diff
—
Reply to this email directly, view it on GitHub
<#427>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGROD3FTTFIQNPRADZ3QW32K3XDHAVCNFSM6AAAAABVILUX2KVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TCMRUHE4TGNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
marcelamelara
approved these changes
Jan 16, 2025
@JustinCappos Fair point. FWIW, these changes aren't prescribing the use of any algorithm in any particular setting, only defining constants to refer to the spec-supported algorithms and their expected hash lengths. |
adityasaky
reviewed
Jan 16, 2025
This commit exposes the known algorithm list as its own type to let programs using the library to use the standarized algorithm names. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
pxp928
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a change to expose the known algorithms in a new type to let programs using the library know the standardized algorithm names. The type has a function to return the expected algorithm length that can be used to validate a hex representation of a hash.
/cc @marcelamelara
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]