-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove method field in signature object examples #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
EDIT: woops.. this a little bit fast.. see my latest comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you missed one method string in this section: https://github.com/in-toto/docs/blob/e6279100ff8b89ae70d5ad1df1757dad6a4b12be/in-toto-spec.md#alice-uses-a-version-control-system
Also we should maybe change this sentence here: The current reference implementation of in-toto defines three signing methods, although in-toto is not restricted to any particular key signing method, key type, or cryptographic library:
signing methods should be changed to schemes?
The method field is neither part of the signature object definition ... https://github.com/in-toto/docs/blame/92483b5b31e34d059445ba132d76d476e6879a11/in-toto-spec.md#L475-L476 ... nor is it included in the reference implementation: https://github.com/in-toto/in-toto/blob/6cfa36cfc2c4b864936560294c032d3bfa869064/tests/demo_files/package.2f89b927.link#L3-L6
Thanks for double-checking! :) Fixed in force-push. |
I think we use methods and schemes interchangeably. |
Ah ok, I thought the sentence is referencing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now
The method field is neither part of the signature object
definition ...
https://github.com/in-toto/docs/blame/92483b5b31e34d059445ba132d76d476e6879a11/in-toto-spec.md#L475-L476
... nor is it included in the reference implementation:
https://github.com/in-toto/in-toto/blob/6cfa36cfc2c4b864936560294c032d3bfa869064/tests/demo_files/package.2f89b927.link#L3-L6