Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method field in signature object examples #34

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Jul 6, 2020

@lukpueh
Copy link
Member Author

lukpueh commented Jul 6, 2020

Just stumbled across this issue while reviewing #34 (cc @shibumi)

@lukpueh lukpueh requested a review from SantiagoTorres July 6, 2020 13:27
Copy link
Contributor

@shibumi shibumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

EDIT: woops.. this a little bit fast.. see my latest comment.

Copy link
Contributor

@shibumi shibumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed one method string in this section: https://github.com/in-toto/docs/blob/e6279100ff8b89ae70d5ad1df1757dad6a4b12be/in-toto-spec.md#alice-uses-a-version-control-system

Also we should maybe change this sentence here: The current reference implementation of in-toto defines three signing methods, although in-toto is not restricted to any particular key signing method, key type, or cryptographic library:

signing methods should be changed to schemes?

@lukpueh lukpueh force-pushed the fix-sig-example branch from e627910 to 55d3b28 Compare July 6, 2020 14:35
@lukpueh
Copy link
Member Author

lukpueh commented Jul 6, 2020

Looks like you missed one method string in this section: https://github.com/in-toto/docs/blob/e6279100ff8b89ae70d5ad1df1757dad6a4b12be/in-toto-spec.md#alice-uses-a-version-control-system

Thanks for double-checking! :) Fixed in force-push.

@lukpueh
Copy link
Member Author

lukpueh commented Jul 6, 2020

signing methods should be changed to schemes?

I think we use methods and schemes interchangeably.

@shibumi
Copy link
Contributor

shibumi commented Jul 6, 2020

Ah ok, I thought the sentence is referencing the method string in the keyformat, but then it's definitely fine.

Copy link
Contributor

@shibumi shibumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants