Add support for new apns-push-type header #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
======================================
Coverage 87.5% 87.5%
======================================
Files 7 7
Lines 216 216
======================================
Hits 189 189
Misses 27 27
Continue to review full report at Codecov.
|
|
hi @essen ! thanks for your contribution to |
|
Probably. |
essen
force-pushed
the
apns-push-type
branch
from
1dfc8cf to
084c944
Compare
|
Let's see what it says. I've changed a little how the default is handled for the new header, simpler like this. |
essen
commented
Sep 13, 2019
As documented here: https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns The header is required on iOS 13+ and a default value had to be chosen. I set it to "alert" as I think it is the most common. Indeed the documentation about "background" said those should be sent two to three times per hour.
essen
force-pushed
the
apns-push-type
branch
from
084c944 to
5ba10b8
Compare
|
All good. |
ferigis
approved these changes
Sep 13, 2019
|
Merged! We are going to create a new release with this change, thanks for your contribution! |
|
Perfect! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented here:
https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns
The header is required on iOS 13+ and a default value had
to be chosen. I set it to "alert" as I think it is the
most common. Indeed the documentation about "background"
said those should be sent two to three times per hour.
Please review but note that I do not have an Apple device personally and this has not been extensively tested yet. Still it's just a header so it's probably good enough.