Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes inaka/elvis#313] Rename application #13

Merged
merged 1 commit into from
Dec 22, 2015
Merged

[Closes inaka/elvis#313] Rename application #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PROJECT = elvis_core
PROJECT = elvis

DEPS = lager zipper katana

Expand All @@ -21,9 +21,7 @@ ERLC_OPTS += +warn_export_vars +warn_exported_vars +warn_missing_spec +warn_unty

TEST_ERLC_OPTS += +'{parse_transform, lager_transform}'
CT_OPTS = -cover test/elvis.coverspec -erl_args -config config/test.config

shell: app
erl -pa ebin -pa deps/*/ebin -name ${PROJECT}@`hostname` -s sync -s elvis_core -s lager -config config/elvis.config
SHELL_OPTS = -name ${PROJECT}@`hostname` -s sync -s elvis_core -s lager -config config/elvis.config

test-shell: build-ct-suites app
erl -pa ebin -pa deps/*/ebin -name ${PROJECT}-test@`hostname` -pa test -s sync -s elvis_core -s lager -config config/test.config
Expand Down
4 changes: 2 additions & 2 deletions src/elvis_core.app.src → src/elvis.app.src
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
application, elvis_core,
application, elvis,
[
{description, "Erlang Style Reviewer, inspired on HoundCI"},
{vsn, "0.2.6-alpha1"},
{applications, [kernel, stdlib, lager, aleppo, zipper]},
{modules,
[
elvis,
elvis_core,
elvis_config,
elvis_result,
elvis_utils,
Expand Down
1 change: 0 additions & 1 deletion test/examples/fail_function_naming_convention.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,3 @@ camelCase(Should, Fail) ->

user@location(Should, Fail) ->
[Should, Fail].

3 changes: 1 addition & 2 deletions test/examples/pass_function_naming_convention.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
-module(pass_function_naming_convention).

-export([snake_case/2]).
-export([snake_case/2, has_digit1/2]).

%% Function names must use only lowercase characters.
%% Words in function names must be separated with _.
Expand All @@ -12,4 +12,3 @@ has_digit1(Should, Pass) ->

snake_case(Should, Pass) ->
[Should, Pass].

2 changes: 1 addition & 1 deletion test/examples/pass_variable_naming_convention.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
%% Cf. https://github.com/inaka/erlang_guidelines#variable-names

should_pass(Should, Pass, Way2Home, Fun1, Fun2) ->
{_IgnoredVariable, _} = ["Ignored but valid", "also valid"],
[_IgnoredVariable, _] = ["Ignored but valid", "also valid"],
Should = "Should",
Pass = "Pass",
Way2Home = "Way to home",
Expand Down