Handle erlang.mk dep_depname_commit format #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In erlang.mk one can specify a dep with repo type, url and commit. But if it is a supported dep, it is enough to mention the commit hash or name of the branch or the tag. Like dep_myrepo = git [email protected]:jonasrichard/myrepo.git master dep_jsx_commit = 2.8.0 In that case the dep variable will be suffixed with _commit. Now elvis fails on them, since it is not a proper repo. This commit fixes that, by filtering out the deps having _commit suffix.
igaray
added a commit
that referenced
this pull request
Jan 12, 2016
Handle erlang.mk dep_depname_commit format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In erlang.mk one can specify a dep with repo type, url and commit.
But if it is a supported dep, it is enough to mention the commit
hash or name of the branch or the tag. Like
dep_myrepo = git [email protected]:jonasrichard/myrepo.git master
dep_jsx_commit = 2.8.0
In that case the dep variable will be suffixed with _commit.
Now elvis fails on them, since it is not a proper repo. This
commit fixes that, by filtering out the deps having _commit
suffix.