Fix macro name resolution (call gets highest precedence)
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to use Ubuntu-20.04 instead of Ubuntu-latest for CI. |
paulo-ferraz-oliveira
changed the title
call gets highest precedence)
The `call` node has to be used with highest precedence when looking for the macro name, as otherwise `-define(CALL(A), some_atom).` will pick `some_atom` as the macro name instead.
filmor
force-pushed
the
fix-macro-name-precedence
branch
from
5aff054 to
ad62dd4
Compare
|
You'll either need to adjust the expected status or I'll put slightly more work into this (tomorrow :)) to make the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
callnode has to be used with highest precedence when looking forthe macro name, as otherwise
-define(CALL(A), some_atom).will picksome_atomas the macro name instead.