Fix #162: New Rule: No Types #270
Conversation
|
|
||
| Avoid `-type` attributes. | ||
|
|
||
| This rule is meant to be used on header files only. |
There was a problem hiding this comment.
This can be restricted by code, right? Or does Erlang accept, for header files, anything other than .hrl?
There was a problem hiding this comment.
Erlang accepts anything. You can 100% write this and it will work…
-include("LICENSE.txt").
-module my_mod.
…Why on Earth will you want to do that is a mystery to me, but it's 100% valid.
There was a problem hiding this comment.
I meant when we're listing the files for analysis we can restrict certain rules to certain file types (not sure if desired).
There was a problem hiding this comment.
This rule is meant to be used on header files only.
But wait, our analysis already is scoped, right? If you use a rebar.config rule on an .erl file it shouldn't work, should it? Not sure I've tried it or we test it, but pretty sure there's some restrictions in place.
Fixes #162 by adding a new rule (
{elvis_style, no_types}) that only applies (by default) to thehrl_filesruleset.