Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #301: Handle maybe matches #302

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Fix #301: Handle maybe matches #302

merged 4 commits into from
Mar 2, 2023

Conversation

elbrujohalcon
Copy link
Member

@elbrujohalcon elbrujohalcon commented Mar 2, 2023 •
edited
Loading

This PR fixes both #301 and #303.

@elbrujohalcon elbrujohalcon added this to the 3.0.0 milestone Mar 2, 2023
@elbrujohalcon elbrujohalcon self-assigned this Mar 2, 2023
pablocostass
pablocostass approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@pablocostass pablocostass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropping by to review this PR as per request of Brujo :)

paulo-ferraz-oliveira
paulo-ferraz-oliveira approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@elbrujohalcon elbrujohalcon merged commit 0184e3b into main Mar 2, 2023
@elbrujohalcon elbrujohalcon deleted the brujo.301.maybe_match branch March 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocostass pablocostass pablocostass approved these changes

@paulo-ferraz-oliveira paulo-ferraz-oliveira paulo-ferraz-oliveira approved these changes

@tak30 tak30 tak30 approved these changes

Assignees

@elbrujohalcon elbrujohalcon

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@elbrujohalcon @tak30 @paulo-ferraz-oliveira @pablocostass