Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance updates #317

Merged
merged 18 commits into from
Aug 7, 2023
Merged

Maintenance updates #317

merged 18 commits into from
Aug 7, 2023

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Aug 6, 2023

This isn't as big as it looks, though there's possibly a lotta changes.

I'll self-review and try to guide you through it to ease the task.

Whenever a change is not super-explicit or supported by the commit message I'll add a comment.

Also closes #307.

Only keep generated stuff + _* (e.g. for _build and _checkouts)
- tweak erl_opts
- bump minimum_otp_vsn
- move test options to `test` profile
- update our dep.s'/plugins' versions
- tweak alias `test`
- tweak `test` profile `dialyzer` and use it to improve the project
- tweak dialyzer options
- add ex_doc
- tweak format options
- tweak hank options
README.md:1:101 MD013/line-length Line length [Expected: 100; Actual: 229]
Version 0.2.19 is failing with an issue I can't understand at the
moment
@paulo-ferraz-oliveira
Copy link
Collaborator Author

I believe you have to change branch protection rules for this
image

CONTRIBUTING.md Show resolved Hide resolved
rebar.config Outdated Show resolved Hide resolved
rebar.config Outdated Show resolved Hide resolved
rebar.config Show resolved Hide resolved
@elbrujohalcon elbrujohalcon merged commit 4d789c4 into inaka:main Aug 7, 2023
@elbrujohalcon
Copy link
Member

Feel free to tag a release and publish to hex whenever you want, @paulo-ferraz-oliveira ;)

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/minor-maintenance-updates branch August 7, 2023 10:58
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Sure. I'll do that now. Thanks.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Can't!

rebar3 hex owner list elvis_core
inaka ([email protected])

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I did the release on GitHub, though 😄, since that one I can.

@elbrujohalcon
Copy link
Member

Let me add you as an owner… hold on.

@elbrujohalcon
Copy link
Member

Try again

@elbrujohalcon
Copy link
Member

Try again, @paulo-ferraz-oliveira

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Yup, that did it. https://hexdocs.pm/elvis_core/readme.html < look at how pretty it looks 😄

@elbrujohalcon
Copy link
Member

Beautiful! I wonder… Is there any way to also publish "Rules.md" and its associated folders and files there?

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Aug 7, 2023

There is, but we'd have to change all the rules' files, because they mention .md, rendered in GitHub (not Hex.pm), not .html. Oh, and I believe we'd have to mention all files individually, which is a maintenance hassle.

Maybe open an issue and we'll tackle it "in the future" 😄

At the moment I'm already sad that hexdocs version prefix is hard-coded to v, which means (below) links to https://github.com/inaka/elvis_core/blob/v3.1.0/README.md#L1 and not https://github.com/inaka/elvis_core/blob/3.1.0/README.md#L1 😭
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken README links
2 participants