Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash on rebar3's pkg aliases #52

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

sstrigler
Copy link
Contributor

rebar3 allows dependency declarations like

{deps,[
  {rebar, {pkg, rebar_fork}}, % rebar app under a different pkg name
]}

elvis crashes at a declaration like this

# rebar.config [FAIL]
Error: 'badarg' while applying rule 'protocol_for_deps_rebar'.
# rebar.config [FAIL]
Error: 'badarg' while applying rule 'protocol_for_deps_rebar'.

This fix prevents elvis from crashing and accepts the declaration as valid.

rebar3 allows dependency declarations like
```
{deps,[
  {rebar, {pkg, rebar_fork}}, % rebar app under a different pkg name
]}
```

elvis crashes at a declaration like this 

```
# rebar.config [FAIL]
Error: 'badarg' while applying rule 'protocol_for_deps_rebar'.
# rebar.config [FAIL]
Error: 'badarg' while applying rule 'protocol_for_deps_rebar'.
```

This fix prevents elvis from crashing and accepts the declaration as valid.
@elbrujohalcon
Copy link
Member

Thank you @sstrigler :)

@elbrujohalcon elbrujohalcon merged commit 88bc2c6 into master Jul 13, 2016
@sstrigler
Copy link
Contributor Author

That was fast 😂

On 13 juli 2016, at 16:11, Brujo Benavides [email protected] wrote:

Merged #52 #52.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #52 (comment), or mute the thread https://github.com/notifications/unsubscribe/AABc6jJngfKKQanQ0eFWfncJP-I9GTj-ks5qVPIUgaJpZM4JLdOA.

@ferigis ferigis deleted the sstrigler-rebar3-pkg-alias branch March 13, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants