[#182] Normalizing tests, postponing ES to #187

inaka · Aug 28, 2015 · a226367 · a226367
1 parent 215f341
commit a226367
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/test/sumo_basic_SUITE.erl b/test/sumo_basic_SUITE.erl
@@ -72,7 +72,9 @@ delete(_Config) ->
   run_all_stores(fun delete_module/1).
 
 check_proper_dates(_Config) ->
-  run_all_stores(fun check_proper_dates_module/1).
+  lists:foreach(
+    fun check_proper_dates_module/1,
+    sumo_test_utils:people_with_proper_dates()).
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %%% Internal functions

diff --git a/test/sumo_config_SUITE.erl b/test/sumo_config_SUITE.erl
@@ -28,8 +28,10 @@
 
 -spec all() -> [atom()].
 all() ->
-  Exports = ?MODULE:module_info(exports),
-  [F || {F, _} <- Exports, not lists:member(F, ?EXCLUDED_FUNS)].
+  case lists:member(sumo_test_people_mysql, sumo_test_utils:all_people()) of
+    true -> [check_overrun_handler];
+    false -> []
+  end.
 
 -spec init_per_suite(config()) -> config().
 init_per_suite(Config) ->

diff --git a/test/sumo_test_people_elasticsearch.erl b/test/sumo_test_people_elasticsearch.erl
@@ -27,12 +27,12 @@
 -spec sumo_schema() -> sumo:schema().
 sumo_schema() ->
   Fields =
-    [sumo:new_field(id,         integer, [id, auto_increment]),
+    [sumo:new_field(id,         string, [id]),
      sumo:new_field(name,       string, [{length, 255}, not_null]),
      sumo:new_field(last_name,  string, [{length, 255}, not_null]),
      sumo:new_field(age,        integer),
-     sumo:new_field(address,    string, [{length, 255}]),
-     sumo:new_field(birthdate,  date),
-     sumo:new_field(created_at, datetime)
+     sumo:new_field(address,    string, [{length, 255}]) %,
+     % sumo:new_field(birthdate,  date),
+     % sumo:new_field(created_at, datetime)
     ],
   sumo:new_schema(?MODULE, Fields).
diff --git a/test/sumo_test_utils.erl b/test/sumo_test_utils.erl
@@ -58,4 +58,4 @@ sleep_if_required(Module) ->
 
 -spec people_with_proper_dates() -> [atom()].
 people_with_proper_dates() ->
-  all_people() -- [sumo_test_people_postgres].
+  all_people() -- [sumo_test_people_elasticsearch].