Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move epgsql deps dir to match rebar location #114

Merged
merged 1 commit into from
Feb 18, 2015
Merged

Conversation

spiegela
Copy link
Contributor

Related to #112. Despite the fix that @jfacorro applied, I still am unable to get it to compile with Rebar.

The issue is related to the dependency directory: Rebar clones the epgsql dependency into deps/epgsql/... and sumo expecting it in deps/pgsql/... I haven't found a way to configure this in Rebar, so I've changed the dependency name to epgsql, configured it in the Makefile and updated sumo_store_pgsql.erl to match. I tested with make & Rebar -- both appear to work.

@elbrujohalcon
Copy link
Member

This looks good, I'll wait for @jfacorro to review it anyway, but just in case you need this later: to change the name of the dep dir in rebar you just need to rename your dep, i.e. from…

{epgsql,      ".*",  {git, "git://github.com/epgsql/epgsql",              "2.0.0"}},

…to…

{pgsql,      ".*",  {git, "git://github.com/epgsql/epgsql",              "2.0.0"}},

@spiegela
Copy link
Contributor Author

@elbrujohalcon Thanks! I thought the something about the rebar config, had tried to change make the change you suggested, but got an error from Rebar when running get-deps:

Pulling pgsql from {git,"git://github.com/epgsql/epgsql","2.0.0"}
Cloning into 'pgsql'...
WARN:  /Users/spiegela/src/dist/spiegela-sumo_db/deps/pgsql/src/epgsql.app.src has application id epgsql; expected pgsql
ERROR: Dependency dir /Users/spiegela/src/dist/spiegela-sumo_db/deps/pgsql failed application validation with reason:
{name_mismatch,{"/Users/spiegela/src/dist/spiegela-sumo_db/deps/pgsql/src/epgsql.app.src",
                {expected,pgsql},
                {has,epgsql}}}.
ERROR: 'get-deps' failed while processing /Users/spiegela/src/dist/spiegela-sumo_db: rebar_abort

@elbrujohalcon
Copy link
Member

oh, man! You're right… so… it seems there is no way to achieve that in rebar. That's odd.

jfacorro added a commit that referenced this pull request Feb 18, 2015
Move epgsql deps dir to match rebar location
@jfacorro jfacorro merged commit 1901b1d into inaka:master Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants