Fixed issue #153, escape queries generated by Riak store. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, only one condition (a tuple).
…er (not inverted), such as they are delivered by DB.
…binaries, now every value is handled as binary. Added riak conditional test.
| sumo:persist(Module, Module:new("Jane", "Doe")), | ||
| sumo:persist(Module, Module:new("John", "Doe", 30, "2015-01-01")), | ||
| sumo:persist(Module, Module:new("Jane Jr.", "Doe", 5, "2015-01-05")), | ||
| sumo:persist(Module, Module:new("Joe", "Armstrong")), |
There was a problem hiding this comment.
According to Elvis:
Remove the dynamic function call on line 49. Only modules that define callbacks should make dynamic calls.
|
@elbrujohalcon now is ready to merge!! |
…test to work with Riak.
| sumo:persist(Module, Module:new("Alan", "Turing", 102, "Computer St.")), | ||
|
|
||
| case Module of | ||
| sumo_test_people_riak -> timer:sleep(5000); |
There was a problem hiding this comment.
I'm very aware that you will hate me… even more… after this comment but: can you keep the style and create a sumo_test_utils:sleep_if_required(Module) and put this case (in a function-head pattern-matching fashion) in it?
That way we will not need to have cases and conditionals checking module names in the tests themselves.
elbrujohalcon
pushed a commit
that referenced
this pull request
May 28, 2015
Fixed issue #153, escape queries generated by Riak store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_querywas totally modified to support different scenarios, not only escape string values but also handle conditions such as:<, <=, >, >=, /=, ==, null, not_null.