Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#182] Fixed sumo_store_riak to support date/datetime fields. #183

Merged
merged 3 commits into from
Aug 28, 2015
Merged

[#182] Fixed sumo_store_riak to support date/datetime fields. #183

merged 3 commits into from
Aug 28, 2015

Conversation

cabol
Copy link
Contributor

@cabol cabol commented Aug 24, 2015

  • Fixed sumo_store_riak to support date/datetime fields.
  • Fixed tests.

@elbrujohalcon elbrujohalcon self-assigned this Aug 24, 2015
elbrujohalcon
elbrujohalcon reviewed Aug 24, 2015
View reviewed changes
src/sumo_store_riak.erl
lists:foldl(Filter, [], SchemaFields).

%% @private
is_datetime(DT) ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be solved better as function clauses instead of a case expression.

@igaray igaray mentioned this pull request Aug 28, 2015
Merged
@jfacorro jfacorro merged commit 9f25ef9 into master Aug 28, 2015
@elbrujohalcon elbrujohalcon deleted the cabol.182.correct_datetime_in_riak_store branch August 28, 2015 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elbrujohalcon elbrujohalcon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cabol @elbrujohalcon @jfacorro