Avoid silently throwing error #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used this code while testing inaka/sumo_db_riak#21 but I have not tested sumo_db in isolation yet. Hopefully tomorrow. Of course if you feel confident to merge anyway, please go ahead. |
With `throw`, tests of sumo_db_riak were failing locally for me with
the following error:
```
%%% basic_SUITE ==> find: SKIPPED
%%% basic_SUITE ==> {tc_auto_skip,
{auto_skipped,{failed,{basic_SUITE,init_per_testcase,{error,0}}}}}
```
that does not provide information on the cause.
With `exit`, the same tests fail with:
```
%%% basic_SUITE ==> find: SKIPPED
%%% basic_SUITE ==> {tc_auto_skip,
{auto_skipped,
{failed,
{basic_SUITE,init_per_testcase,
{{error,0},
[{sumo,delete_all,1,
[{file,
"/Users/luca/dev/vuk/inaka_crud/sumo_db_riak/_build/default/lib/sumo_db/src/sumo.erl"},
{line,227}]},
{sumo_basic_test_helper,init_store,1,
[{file,
"/Users/luca/dev/vuk/inaka_crud/sumo_db_riak/_build/default/lib/sumo_db/src/adapter_test_helpers/sumo_basic_test_helper.erl"},
{line,165}]},
{basic_SUITE,init_per_testcase,2,
[{file,
"/Users/luca/dev/vuk/inaka_crud/sumo_db_riak/_build/test/lib/sumo_db_riak/test/basic_SUITE.erl"},
{line,51}]},
{test_server,do_init_per_testcase,2,
[{file,"test_server.erl"},{line,1297}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1007}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,977}]}]}}}}}
```
See also:
* inaka/erlang_guidelines#70
* inaka/erlang_guidelines#71
|
Rebased on PR #291 in order to benefit from CI running tests. |
lucafavatella
changed the title
|
Travis CI finally triggered, I eye-balled the two jobs, look good and ready to merge. Open to comments though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not setup running tests locally yet, so opening PR so that any bots configured can do their job and in the meantime I will try to figure out how to run tests.