[#321] In sumo_store add handle_info and terminate as optional callbacks
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabol
force-pushed
the
cabol.321.optional_callbacks
branch
2 times, most recently
from
47fa951 to
67fc74e
Compare
elbrujohalcon
requested changes
Jul 18, 2017
src/sumo_store.erl
Outdated
| true -> Handler:handle_info(Info, HState); | ||
| false -> {noreply, State} | ||
| catch | ||
| _:Reason -> {stop, Reason, State} |
There was a problem hiding this comment.
Instead of _, you should use Reason and you should not stop, but treat that as a result.
src/sumo_store.erl
Outdated
| true -> Handler:terminate(Reason, HState); | ||
| false -> ok | ||
| catch | ||
| _:_ -> ok |
There was a problem hiding this comment.
Instead of _, you should use throw specifically.
cabol
force-pushed
the
cabol.321.optional_callbacks
branch
from
67fc74e to
31aa801
Compare
src/sumo_store.erl
Outdated
| handle_info(Info, #state{handler = Handler, handler_state = HState} = State) -> | ||
| case erlang:function_exported(Handler, handle_info, 2) of | ||
| true -> | ||
| try |
There was a problem hiding this comment.
Nitpicking, but I thing the proper way to do this would be:
try Handler:handle_info(Info, HState) of
Response -> handle_info_response(Response, State)
elbrujohalcon
approved these changes
Jul 19, 2017
…callbacks
cabol
force-pushed
the
cabol.321.optional_callbacks
branch
from
31aa801 to
9b4d3fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
sumo_storeaddhandle_infoandterminateas optional callbacks