Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes #62] Rename repos to store. #96

Merged
merged 4 commits into from
Nov 18, 2014
Merged

Conversation

jfacorro
Copy link
Contributor

No description provided.

@@ -123,7 +123,7 @@ sumo_schema() ->
% -spec total_posts(sumo:schema_name(), State ) -> {ok, {raw, non_neg_integer()}, State} | {ok, error, State}.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 123 is too long: "% -spec total_posts(sumo:schema_name(), State ) -> {ok, {raw, non_neg_integer()}, State} | {ok, error, State}.".


### Deprecated

- None.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mother and UNIX taught me "if you have nothing interesting to say, say nothing".
I like the Added / Deprecated / Removed / Fixed template, but having lots of subsections with nothing but "None" creates a bit of noise, what do you think of having commented template with all sections, and removing those which have nothing useful to say?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a lot clearer to specifically indicate that there are no items under each section, so that people don't think we've forgotten to add something to the list. I've seen this suggested in a couple of places.

igaray added a commit that referenced this pull request Nov 18, 2014
@igaray igaray merged commit 65dca09 into master Nov 18, 2014
@jfacorro jfacorro deleted the jfacorro.62.rename.repos branch November 18, 2014 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants