Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glassmorphism to landing page #11

Merged
merged 5 commits into from
Jan 6, 2021
Merged

add glassmorphism to landing page #11

merged 5 commits into from
Jan 6, 2021

Conversation

tusharnankani
Copy link

@tusharnankani tusharnankani commented Jan 4, 2021

What is the change?

Added Glassmorphism to the landing page.

Related issue?

In reference to #4

Files edited?

  • views/partials/header.ejs
  • public/css/index.js

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes like this ([x]).

  • I've checked there aren't other open Pull Requests for the same update/change?
  • I've made corresponding changes to the documentation?
  • My submission doesn't break any existing feature.
  • I've tested this code locally before submission?

Current behavior

hashcode_glassmorphism.mp4

@Nishant2907

Nishant2907 and others added 4 commits December 18, 2020 01:59
* updated readme

* updated readme

* updated readme

* updated readme

* updated readme

* updated

* updated readme

* updated readme

* updated readme

* updated

* updated readme

* changed color

* updated

* updated

* updated

* updated readme

* updated readme

* updated

* updated

* updated
@Nishant2907
Copy link
Member

looks good to me, it will be great if you can work on the courses card sections and on the footer too.
Any ideas on those sections will be appreciated.

@tusharnankani
Copy link
Author

Yes, I will create atomic separate PRs for the footer and navbar.

@tusharnankani
Copy link
Author

@Nishant2907 any updates?

Copy link
Member

@Nishant2907 Nishant2907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@Nishant2907 Nishant2907 changed the base branch from master to develop January 6, 2021 18:06
@Nishant2907 Nishant2907 merged commit 43f78c7 into inaxia:develop Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants