Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional checking to register component only once #5

Merged
merged 10 commits into from
Aug 11, 2016

Conversation

vvscode
Copy link
Collaborator

@vvscode vvscode commented Sep 1, 2015

After Ember update there are code, which check if component was already registered. And on trying to reregister component -- it's throw an error.

Old implementation register component on every initialization ( we've got an error on multiple wysiwyg at form )

@asaf
Copy link
Contributor

asaf commented Aug 7, 2016

Hey @vvscode,

Would you like to be a maintainer of the project?

Thanks

@vvscode
Copy link
Collaborator Author

vvscode commented Aug 7, 2016

@asaf I'm not sure )) We use component in our project, and in general it works fine for me ( cause we can update structure for modern ember ). I'm ready to contribute if you have some issues --just create issue and add mention for me

@asaf
Copy link
Contributor

asaf commented Aug 10, 2016

@vvscode I can make you a moderator and you can actually merge these changes by yourself :-)

@vvscode
Copy link
Collaborator Author

vvscode commented Aug 10, 2016

@asaf thx. Hope I'll justify your trust

@vvscode vvscode merged commit fc4e9ec into indexiatech:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants