Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Uncaught exception when getting nested keys #65

Closed
indexzero opened this issue Dec 20, 2012 · 2 comments
Closed

Regression: Uncaught exception when getting nested keys #65

indexzero opened this issue Dec 20, 2012 · 2 comments

Comments

@indexzero
Copy link
Owner

When you set something to a string value and then attempt to get a child of that string value an unhandled Error is thrown.

This is a direct caused by incorrect use of the in keyword in #49

e.g.

  var nconf = require('nconf');
  nconf.set('foo:bar', 'SOME_STRING_VAUE');

  console.log(
    nconf.get('foo:bar:doesnt:exist') // should be undefined but throws
  );
@mhart
Copy link
Contributor

mhart commented Dec 20, 2012

The in keyword? I don't think I used that at all in #49 :

https://github.com/flatiron/nconf/pull/49/files

@mhart
Copy link
Contributor

mhart commented Dec 20, 2012

Again, I really don't see how this is related to #49 at all - but the fix is trivial: in #66

indexzero added a commit that referenced this issue Dec 20, 2012
indexzero added a commit that referenced this issue Dec 20, 2012
indexzero pushed a commit that referenced this issue Dec 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants