Remove questionable show_save_button logic

course/flow.py

@@ -1711,11 +1711,9 @@ def add_buttons_to_form(
         flow_session: FlowSession,
         permissions: frozenset[str]) -> StyledForm:
     from crispy_forms.layout import Submit
-    show_save_button = getattr(form, "show_save_button", True)
-    if show_save_button:
-        form.helper.add_input(
-                Submit("save", _("Save answer"),
-                    css_class="relate-save-button"))
+    form.helper.add_input(
+            Submit("save", _("Save answer"),
+                css_class="relate-save-button"))
 
     if will_receive_feedback(permissions):
         if flow_permission.change_answer in permissions:

course/page/text.py

@@ -1150,9 +1150,6 @@ def get_validators(self):
 # {{{ rich text
 
 class RichTextAnswerForm(StyledForm):
-    # FIXME: ugh, this should be a PageBase thing
-    show_save_button = False
-
     def __init__(self, read_only: bool, *args: Any, **kwargs: Any) -> None:
         super().__init__(*args, **kwargs)
 

course/page/upload.py

@@ -44,7 +44,6 @@
 # {{{ upload question
 
 class FileUploadForm(StyledForm):
-    show_save_button = False
     uploaded_file = forms.FileField(required=True,
             label=gettext_lazy("Uploaded file"))
 

tests/test_flow/test_flow.py

@@ -3992,20 +3992,6 @@ def get_form_submit_inputs(self, form):
         values = list(dict(inputs).values())
         return names, values
 
-    def test_not_add_save_button(self):
-        class MyForm(StyledForm):
-            show_save_button = False
-
-        form = MyForm()
-
-        self.mock_will_receive_feedback.return_value = True
-        flow.add_buttons_to_form(form, self.fpctx, self.flow_session, frozenset())
-
-        names, values = self.get_form_submit_inputs(form)
-        self.assertNotIn("save", names)
-        self.assertIn("submit", names)
-        self.assertIn("Submit final answer", values)
-
     def test_add_save_button_by_default(self):
         class MyForm(StyledForm):
             pass