Turn ResolvedPos.column and ResolvedSpan.end into properties #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResolvedPos.column and ResolvedSpan.end are currently exposed as methods instead of properties. This is not consistent with having ResolvedPos.line and ResolvedSpan.begin being exposed as properties.
|
Makes sense, thanks! Technically it's breaking compatibility, but I suspect this doesn't have super many users just yet, so it's probably OK. |
|
Yes, I thought about backwards compatibility as well... I assumed that if these particular fields were used, "somebody" would have seen the discrepancy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResolvedPos.column and ResolvedSpan.end are currently exposed as methods instead of properties. This is not consistent with having ResolvedPos.line and ResolvedSpan.begin being exposed as properties.