Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer constructor runtime deprecation - this package emits a warning on Node 10 #102

Closed
benjamingr opened this issue Mar 20, 2018 · 0 comments
Closed

Buffer constructor runtime deprecation - this package emits a warning on Node 10 #102

benjamingr opened this issue Mar 20, 2018 · 0 comments

Comments

@benjamingr
Copy link

Hey, this repo was tagged in nodejs/node#19079 (comment)

Just making sure this is tracked and you're aware that new Buffer is runtime-deprecated in v10.
ChALkeR added a commit to ChALkeR/asn1.js that referenced this issue Mar 22, 2018
@ChALkeR
Use Buffer.(from|alloc) instead of deprecated Buffer API
d0fa433 
This also includes a dependnecy on a polyfill targeting older Node.js
versions where Buffer.alloc() and Buffer.from() API is not implemented
(Node.js < 4.5.0 and some 5.x versions).

Fixes: indutny#102

Ref: nodejs/node#19079
Ref: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Ref: https://nodejs.org/api/buffer.html#buffer_class_buffer
Ref: https://github.com/ChALkeR/safer-buffer/blob/master/Porting-Buffer.md
@ChALkeR ChALkeR mentioned this issue Mar 22, 2018
Closed
@exoego exoego mentioned this issue Sep 12, 2019
Closed
@fanatid fanatid mentioned this issue Sep 13, 2019
Open
@indutny indutny closed this as completed in e186699 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@benjamingr