Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the extension name when we fail to embed something. #272

Closed
wants to merge 1 commit into from

Conversation

stuhood
Copy link
Contributor

@stuhood stuhood commented Jun 18, 2020

When a PythonExtensionModule is discovered via a batch-discovery method like read_package_root or pip_install, "which" module is causing the trouble is not obvious. Rendering the extension module name gives information about the culprit (although it will not pinpoint a file on disk or requirements.txt entry precisely).

@indygreg
Copy link
Owner

I rebased and pushed as 7c3b3f6.

@indygreg indygreg closed this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants