Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wheel for arm64 macos #137

Closed
wants to merge 3 commits into from
Closed

Conversation

glandium
Copy link
Contributor

No description provided.

@glandium
Copy link
Contributor Author

Ideally, it would be possible to build wheels for python 3.8, but cibuildwheel doesn't allow it (it can't use the python from xcode/command line tools).

@glandium
Copy link
Contributor Author

Note that I tested the arm64 python 3.8 wheel produced from running a reduced workflow on my fork of the repo, and it works. I don't have python 3.9 to test.

Copy link
Owner

@indygreg indygreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have access to an M1 machine in ~10 days. Unless you have objections, I'm going to sit on this PR until I can properly test the wheels.

ci/requirements.macoswheels.in Outdated Show resolved Hide resolved
Upstream python only support arm64 starting from python 3.9, but Xcode
ships with an arm64 python 3.8. As cibuildwheel doesn't support using
Xcode's python, handle this case manually.
@glandium
Copy link
Contributor Author

Have you had the chance to look now that you have your M1 according to your tweets? :)

Copy link
Owner

@indygreg indygreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Using the "system" Python outside of arm64 builds is a bit wonky. But it shouldn't matter: cibuildwheel should take care of ensuring things behave as expected. I'm not too worried about this doing anything wrong. Although I wouldn't be surprised if I change the logic in the future to only be for arm64 builds. Although hopefully in the future we have arm64 Apple machines in GitHub Actions and this whole mess can be simplified.

@indygreg
Copy link
Owner

I pushed this as 1077372..dae2aab but GitHub couldn't figure that out. Thanks for the contribution.

@indygreg indygreg closed this Feb 26, 2021
@glandium
Copy link
Contributor Author

Do you have an ETA for next release?

@indygreg
Copy link
Owner

Would you like there to be a release soon?

I wasn't planning to release any time soon since there aren't any major changes queued up. But if there's a business case for releasing, I could do it in the next few days.

@glandium
Copy link
Contributor Author

The arm64 wheels would be useful. A 0.15.x release with them would be nice to have, but if you don't have the bandwidth for that, I can wait.

@glandium glandium deleted the arm64-mac branch February 27, 2021 01:11
@indygreg
Copy link
Owner

I've got the 0.15.2 release queued up. Waiting on GitHub Actions to finish processing the wheels. (The wait times on macOS machines can be really bad sometimes.) I should have things published to PyPI within a few hours.

@indygreg
Copy link
Owner

0.15.2 was just published to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants