Post Infinispan 10 integration tasks #140
Conversation
|
Fixing CI... |
|
Added documentation for security changes (cc @oraNod), and refactored CR examples to highlight each independent set of examples. |
|
Forced pushed branch to fix issue that was making CI fail |
|
The issue I'm having with creating CRDs using the controller runtime API might be related to controller-runtime#321. I'm exploring alternatives proposed there. Otherwise can always revert to the previous method for creating/instantiating CRDs. A PR is currently being discussed to avoid this issue. |
|
That worked, I'll tidy up the commits. |
|
Squashed the CI fix (temporary workaround to use a dynamic rest mapper) to the refactoring commit. Let's see if CI agrees :) |
|
CI looks good @rigazilla |
|
@galderz ok. Testing locally |
|
tests are ok locally in all the k8s flavours: minikube, os 3.11, os 4.1. |
|
@rigazilla Fixed you comments and pushed. Let's see CI... |
* Only convert to string formats in the last minute. * This makes the functions more typesafe.
* The operator gets given a Kubernetes client via the controller. Refactor kubernetes code to use that, or resolve Kubernetes config locally. * A bug in controller-runtime API means that if a CRD is created, this won't be found by the client until it's recreated. * Temporarily workaround it by using a dynamic REST mapper.
* It makes sense to have multiple CR examples, but to avoid confusing users, each set should be stored in its independent folder.
* Further configuration should be consulted in the official documentation.
|
thank you! |
Resolve #120, #121 and #122
Also refactored all Kubernetes code to use just one client API: the one provided by the controller. This way, we can load up the Kubernetes helper method from either the controller manager, or external configuration.
The controller API is less typesafe, which might be harder to use compared to the typed one, but it also offers more possibilities for further simplification of the API, since a lot of calls are very similar and only differ in parameters.
Documentation for the security changes will be added in a later commit (either in this PR or a separate one)