Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define multiple slack nodes in Kapacitor #2855

Closed
2 tasks done
russorat opened this issue Feb 26, 2018 · 8 comments
Closed
2 tasks done

Add ability to define multiple slack nodes in Kapacitor #2855

russorat opened this issue Feb 26, 2018 · 8 comments
Assignees
Milestone

Comments

@russorat
Copy link
Contributor

russorat commented Feb 26, 2018

connect influxdata/kapacitor#1696

  • ensure that the latest changes hasn't broken the existing slack config in chronograf
  • add the ability to configure multiple slack integrations in chronograf
@jaredscheib
Copy link
Contributor

jaredscheib commented Apr 3, 2018

Blocked until all of the TypeScript conversion work that @ischolten is doing for #2786 is separated out as its own PR, submitted, and merged into master.

@alexpaxton
Copy link
Contributor

screen shot 2018-04-04 at 10 13 54 am

If the user configures the slack endpoint, a second slack endpoint appears. If the user configures the second endpoint a third appears. This pattern allows for as many slack configs as necessary with as little changes to UI as possible

@russorat
Copy link
Contributor Author

russorat commented Apr 4, 2018

how do the tabs look when they scroll? Also, we have a PagerDuty v2 and OpsGenie v2, will users think this is Slack v2?

@russorat russorat added this to the 1.5.0 milestone Apr 17, 2018
@alexpaxton
Copy link
Contributor

I'm working on a better design

@alexpaxton
Copy link
Contributor

Changes:

  • Configure --> Configured
  • Green checkmarks are no longer necessary, as the list only shows configured endpoints
  • Add an Endpoint dropdown shows full list of endpoints that can be configured
  • Selecting an endpoint from the dropdown adds it as a tab in the list
  • Some can be added multiple times

screen shot 2018-04-23 at 12 07 06 pm
screen shot 2018-04-23 at 12 07 46 pm

  • Dropdown in Alert Rule Builder uses li.dropdown-headers to delineate more clearly the two sections in the menu
  • If there are multiple Slack endpoints (for example) then Slack shows up twice in the menu

screen shot 2018-04-23 at 12 32 40 pm

@alexpaxton
Copy link
Contributor

alexpaxton commented Apr 26, 2018

Spent some more time experimenting with the design. Considering that we may redesign much of the kapacitor config UI in the future it is more strategic to do something really simple for now. Essentially, users will be able to create multiple "configs" within the same tab for an endpoint. If there are multiple configurations each one requires a nickname.

screen shot 2018-04-26 at 11 27 58 am

If multiple configurations exist, each has a Delete button to remove it entirely. If there is only a single configuration there is no Delete button
multiple-endpoints-delete-v2

Nicknames are exposed in this dropdown:
screen shot 2018-04-26 at 11 36 16 am

Even though multiple configurations appear in the same tab, they should be treated as individual configurations with their own saving/testing functionality

@russorat
Copy link
Contributor Author

looks good!

@russorat
Copy link
Contributor Author

russorat commented May 16, 2018

  • parse error when trying to save a second slack node without filling in an id. error should be shown to the user.
  • alert builder, when switching to a different slack node, does not update the script (see below)
    kapture 2018-05-16 at 14 32 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants