Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple slack nodes #3465

Merged
merged 22 commits into from
May 15, 2018
Merged

Multiple slack nodes #3465

merged 22 commits into from
May 15, 2018

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented May 15, 2018 •
edited
Loading

Closes #2855

Briefly describe your proposed changes:
Add ability to create multiple slack configurations.
Update kapacitor dependencty to rc-tag 4

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

ischolten and others added 22 commits May 15, 2018 14:57
@ischolten
Add nickname field to SlackConfig form
5c07acf
@ischolten
Add ability to display multiple slack nodes in UI
1c2c422
@ischolten
Add ability to create new slack node
342402d
@ischolten
Fix unique id errors and update keys for slack configs
ce39c0a
@ischolten
Update handleSubmit to only send workspace in properties if a new config
2ed842c
@ischolten
Update SlackConfig to disable nickname if its a new config
2f8b275
@ischolten
Change updateKapacitorConfigSection function so that if a specific co…
5330d2c 
…nfig is passed, it updates that specific config and not just the default
@ischolten
Add delete button and funcitonality for SlackConfigs
dbd32a9
@ischolten
Update parseHandlersFromConfig to include config sections with multip…
64f9ec9 
…le configs
@ischolten
Add nickname to display text in Alert Handlers section to use nickname
d29275d
@ischolten
Update parseAlertNodesList to use nicknames with slack
0b549ee
@ischolten
Update placeholders for nicknames in SlackConfig based on whether its…
4613c9f 
… the default config or not
@ischolten
Fix bug where clicking enabled on a new config toggled the default sl…
a0b55d1 
…ack config
@ischolten @alexpaxton
Style the Multiple slack nodes
a64437a 
Co-authored-by: Alex Paxton <[email protected]>
@ischolten
Update testAlertOutput to use specific config if using slack
6b24cd2
@ischolten
Convert HandlerTabs, RuleHandlers, and Kapacitor/Constants/Index to t…
08337f3 
…ypescript and fix any type in SlackConfigs
@ischolten
Refactor AlertTabs for typing
1a4556a
@ischolten
Update Kapacitor dependency to rc4 and run dep ensure
3611754
@ischolten
Prevent the deletion of an unsaved new slack config from deleting the…
5bab456 
… default slack config
@ischolten
Update getConfigEnabled to check if any configs are enabled if multil…
7616e28 
…pe configs exist for a section
@ischolten
Add additional options to override for testing slack config
801cdc2
@ischolten
Update changelog
8caf7d9
@ischolten ischolten merged commit 753d378 into master May 15, 2018
@ischolten ischolten deleted the feature/multiple-slack-nodes branch May 15, 2018 22:57
@russorat russorat mentioned this pull request May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthesorceror bthesorceror bthesorceror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischolten @bthesorceror