TICKscript Editor #1721

121watts · 2017-07-13T23:45:14Z

CHANGELOG.md updated with a link to the PR (not the Issue)
Rebased/mergable
Tests pass
Sign CLA (if not already signed)

Connect #789

The problem

Sometimes you just want to write your own tick script.

The Solution

Provide a text editor for the user to do so.

alexpaxton · 2017-07-26T04:58:50Z

WIP screenshot

lukevmorris · 2017-08-15T16:42:37Z

Blocked on #1733

Had to downgrade react-codemirror due to a bug. Issues and PRs are open to resolve: - JedWatson/react-codemirror#121 - JedWatson/react-codemirror#106

cryptoquick · 2017-09-15T11:24:05Z

First, I'm glad we can finally get this in, so great work, to everyone involved
I double-checked your refactor of MultiSelectDropdown, it should be good
I'm not sure if this is a regression, but saving a rule if there is an error now produces a copy of that rule, not sure if this is good or desired behavior... I've replicated it in code outside this branch, and made an issue for it. #1998
More to come, this is a very large PR, please be patient as I review it.

cryptoquick

Found a few issues. Let's get these fixed and then I can continue testing.

I went over all the code and it looks great, especially the SFCs for Tables and stuff.

cryptoquick · 2017-09-22T19:20:54Z

ui/package.json

@@ -112,6 +113,8 @@
    "query-string": "^5.0.0",
    "react": "^15.0.2",
    "react-addons-shallow-compare": "^15.0.2",
+    "react-addons-update": "^15.1.0",


cryptoquick · 2017-09-22T20:38:39Z

ui/src/admin/components/UserRow.js

-              items={allPermissions}
-              selectedItems={_.get(permissions, ['0', 'allowed'], [])}
+              items={allPermissions.map(p => ({name: p}))}
+              selectedItems={perms.map(p => ({name: p}))}


There's something wrong with the permissions dropdowns on Enterprise, they list items but don't display the text.

Also, selecting one selects them all.

This has been fixed, but other issues with the backend have come up. See #2021

cryptoquick · 2017-09-22T20:45:49Z

ui/src/kapacitor/actions/view/index.js

+    return data
+  } catch (error) {
+    if (!error) {
+      dispatch(errorThrown('Could not communicate with server'))


Do you think we should communicate a more meaningful error message from the backend if there's one available? We do a really bad job of obscuring things that are available and come back from the server, and we just swallow those messages.

I agree 💯

Let's do this in an another issue, like #1539 .

…onograf into feature/tickscript-editor

cryptoquick · 2017-09-22T22:26:23Z

Good stuff, reviewed and ready for merge.

121watts added the ready for review label Jul 13, 2017

121watts force-pushed the feature/tickscript-editor branch 2 times, most recently from d5c301b to a4be143 Compare July 25, 2017 20:38

121watts force-pushed the feature/tickscript-editor branch from 1553ee2 to 50499c8 Compare August 7, 2017 22:07

nhaugo added the blocked label Aug 8, 2017

desa mentioned this pull request Aug 9, 2017

Add ability to load tasks/handlers from dir influxdata/kapacitor#1481

Merged

12 tasks

121watts force-pushed the feature/tickscript-editor branch from 6a283b4 to df57189 Compare September 7, 2017 17:07

goller mentioned this pull request Sep 7, 2017

Update kapacitor rules API to include dbrps, various dates, error, and executing #1978

Merged

4 tasks

121watts and others added 20 commits September 12, 2017 09:23

Add skeleton for tickscript editor page

423f02b

Introduce TICKscript editor

b5aa82f

Introduce CodeMirror for TICKscript editor

202702b

Polish the editor

ad1f78a

Display TICKscript on rules index

8722120

Polish alert rules table

1e1c955

Update CHANGELOG

c4562aa

Update kapacitor links to include tasks and ping paths

b66be55

ES6ify

b6880c2

Introduce skeleton to create task through proxy

4f1372a

WIP Edit scripts returned from the server

b6ca021

Had to downgrade react-codemirror due to a bug. Issues and PRs are open to resolve: - JedWatson/react-codemirror#121 - JedWatson/react-codemirror#106

Introduce TICKscript editing

cea9d07

Set default props for ruleID

9f371f1

Add lambda to syntax highlighting

0e8fecf

Apply selected dbrps to state

4437475

Prettier

fa2192f

Add comment

026b1f1

Add ability to apply changes per click

018bd17

Make UserRow work with new MultiSelectDropdown shape

1cdcc80

Cleanup checks with default props

74145b0

121watts and others added 7 commits September 12, 2017 09:23

Make task ids only edit when making new task

c653982

Prettier

25d5310

Organize styles and use custom theme for code mirror

09d554c

Change layout of tickscript editor

077bdf2

Update to react-codemirror 1.0

cce44b1

Update branch with new linter rules

b817c82

Use /rules to create tickscripts

b151e81

121watts force-pushed the feature/tickscript-editor branch from df57189 to b151e81 Compare September 12, 2017 18:03

121watts added 2 commits September 12, 2017 11:44

Update existing tickscript

4915e97

Fix auto indendation to match indentation of previous line

f7d59f6

121watts removed the blocked label Sep 12, 2017

121watts added 5 commits September 12, 2017 14:25

Publish notification after route change

701c4bf

Remove TICKscript name creation

dc7fc85

Use tickscript id as 'name' for raw tickscripts

6dd8e37

Add a TICKscript table to alert rules page

e646f42

Refine copy

e314789

121watts changed the title ~~WIP Tickscript Editor~~ Tickscript Editor Sep 14, 2017

Update CHANGELOG

2fdee35

121watts changed the title ~~Tickscript Editor~~ TICKscript Editor Sep 14, 2017

Merge branch 'master' into feature/tickscript-editor

9059da0

cryptoquick self-requested a review September 15, 2017 11:24

cryptoquick suggested changes Sep 22, 2017

View reviewed changes

121watts added 3 commits September 22, 2017 15:07

Fix multiselect in Admin page

f5209a8

Merge branch 'feature/tickscript-editor' of github.com:influxdata/chr…

4abe50e

…onograf into feature/tickscript-editor

Remove react-addons-update

abbcd6c

cryptoquick approved these changes Sep 22, 2017

View reviewed changes

121watts merged commit c95aeab into master Sep 27, 2017

121watts deleted the feature/tickscript-editor branch September 27, 2017 22:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TICKscript Editor #1721

TICKscript Editor #1721

121watts commented Jul 13, 2017 •

edited

Loading

alexpaxton commented Jul 26, 2017

lukevmorris commented Aug 15, 2017

cryptoquick commented Sep 15, 2017 •

edited

Loading

cryptoquick left a comment

cryptoquick Sep 22, 2017

cryptoquick Sep 22, 2017

cryptoquick Sep 22, 2017

cryptoquick Sep 22, 2017

cryptoquick Sep 22, 2017

121watts Sep 22, 2017

cryptoquick Sep 22, 2017

cryptoquick commented Sep 22, 2017

TICKscript Editor #1721

TICKscript Editor #1721

Conversation

121watts commented Jul 13, 2017 • edited Loading

The problem

The Solution

alexpaxton commented Jul 26, 2017

lukevmorris commented Aug 15, 2017

cryptoquick commented Sep 15, 2017 • edited Loading

cryptoquick left a comment

Choose a reason for hiding this comment

cryptoquick Sep 22, 2017

Choose a reason for hiding this comment

cryptoquick Sep 22, 2017

Choose a reason for hiding this comment

cryptoquick Sep 22, 2017

Choose a reason for hiding this comment

cryptoquick Sep 22, 2017

Choose a reason for hiding this comment

cryptoquick Sep 22, 2017

Choose a reason for hiding this comment

121watts Sep 22, 2017

Choose a reason for hiding this comment

cryptoquick Sep 22, 2017

Choose a reason for hiding this comment

cryptoquick commented Sep 22, 2017

121watts commented Jul 13, 2017 •

edited

Loading

cryptoquick commented Sep 15, 2017 •

edited

Loading