Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpsGenie v2 to UI #3369

Merged
merged 10 commits into from
May 5, 2018
Merged

Add OpsGenie v2 to UI #3369

merged 10 commits into from
May 5, 2018

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented May 4, 2018

Closes #2929

Briefly describe your proposed changes:
Add config in UI for OpsGenie v2
Update kapacitor dependency to 1.5 rc 2

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • swagger.json updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

const {configSections} = this.state
const {hash} = this.props

// console.log(configSections)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this? 😄

@@ -345,7 +376,7 @@ class AlertTabs extends Component {
<TabList customClass="config-endpoint--tabs">
{_.reduce(
configSections,
(acc, _cur, k) => {
(acc, __, k) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@bthesorceror bthesorceror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, one console log to remove but other than that looks good.

@jaredscheib
Copy link
Contributor

jaredscheib commented May 4, 2018

I'm going to merge in order to not have conflicts with my current branch, which will use the TypeScript work here, and let @ischolten update swagger for the new OpsGenie2 config upon her return: #3382.

@jaredscheib jaredscheib merged commit 1bdc81f into master May 5, 2018
@jaredscheib jaredscheib deleted the feature/opsgenie-v2 branch May 5, 2018 00:00
@ischolten
Copy link
Contributor Author

Swagger was updated by PR #3398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants