Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes topic saving for kafka handler #3501

Merged
merged 1 commit into from
May 22, 2018
Merged

Fixes topic saving for kafka handler #3501

merged 1 commit into from
May 22, 2018

Conversation

bthesorceror
Copy link
Contributor

@bthesorceror bthesorceror commented May 22, 2018 •
edited
Loading

Closes #2904

  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

ischolten
ischolten approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@ischolten ischolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bthesorceror bthesorceror merged commit 3b0b3d2 into master May 22, 2018
@bthesorceror bthesorceror deleted the fixes/saving-topic-kafka branch May 22, 2018 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ischolten ischolten ischolten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bthesorceror @ischolten