revert: "refactor: Remove the need for the flux_test_gen files (#4729)" #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bad49e3. This commit is attempting to remove the flux files to ast generation. The problem with this is that downstream projects use this list of tests to run end to end tests so it's not that simple to just remove these files for those legacy tests.
scbrickley
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bad49e3.
This commit is attempting to remove the flux files to ast generation.
The problem with this is that downstream projects use this list of tests
to run end to end tests so it's not that simple to just remove these
files for those legacy tests.
Done checklist