Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added mutex lock and unlock around read to logger struct for con… #276

Merged
merged 1 commit into from
Sep 16, 2021
Merged

fix: added mutex lock and unlock around read to logger struct for con… #276

merged 1 commit into from
Sep 16, 2021

Conversation

shubhamcoc
Copy link
Contributor

@shubhamcoc shubhamcoc commented Sep 8, 2021 •
edited
Loading

…current use

Closes #

Proposed Changes

Mutex lock for reading to logger struct for concurrent clients. Race conditions occur if one client uses the Info function and the other client sets the log level.

Checklist

  • Rebased/mergeable
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@shubhamcoc
Copy link
Contributor Author

@vlastahajek kindly review this patch

vlastahajek
vlastahajek approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhamcoc, thanks for the PR!

@vlastahajek vlastahajek merged commit 18cfd3d into influxdata:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlastahajek vlastahajek vlastahajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhamcoc @vlastahajek